nexus: fix tests breaking unless single threaded #926
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
force-pushed
the
mt-cargo-test
branch
2 times, most recently
from
a1b4c3d to
5991c38
Compare
serprex
commented
Dec 28, 2023
serprex
force-pushed
the
mt-cargo-test
branch
3 times, most recently
from
3e65308 to
aff9d3c
Compare
serprex
added a commit
that referenced
this pull request
Dec 29, 2023
Currently server_tests must be run with --test-threads=1 because of two things: 1. port collision 2. concurrent migrations failing I explored fixing these in #926. Ports are easily solved, but migrations are a pain This migration code works around concurrency with two changes from refinery: 1. ignore unique constraint violation from CREATE TABLE IF NOT EXISTS 2. lock migration table so concurrent migrations are serialized Considered submitting a PR to refinery with these two fixes, but this simple change was non trivial since they support multiple async/sync database drivers
serprex
added a commit
that referenced
this pull request
Dec 29, 2023
Currently server_tests must be run with --test-threads=1 because of two things: 1. port collision 2. concurrent migrations failing I explored fixing these in #926. Ports are easily solved, but migrations are a pain This migration code works around concurrency with two changes from refinery: 1. ignore unique constraint violation from CREATE TABLE IF NOT EXISTS 2. lock migration table so concurrent migrations are serialized Considered submitting a PR to refinery with these two fixes, but this simple change was non trivial since they support multiple async/sync database drivers
serprex
added a commit
that referenced
this pull request
Dec 29, 2023
Currently server_tests must be run with --test-threads=1 because of two things: 1. port collision 2. concurrent migrations failing I explored fixing these in #926. Ports are easily solved, but migrations are a pain This migration code works around concurrency with two changes from refinery: 1. ignore unique constraint violation from CREATE TABLE IF NOT EXISTS 2. lock migration table so concurrent migrations are serialized Considered submitting a PR to refinery with these two fixes, but this simple change was non trivial since they support multiple async/sync database drivers
serprex
added a commit
that referenced
this pull request
Dec 29, 2023
Currently server_tests must be run with --test-threads=1 because of two things: 1. port collision 2. concurrent migrations failing I explored fixing these in #926. Ports are easily solved, but migrations are a pain This migration code works around concurrency with two changes from refinery: 1. ignore unique constraint violation from CREATE TABLE IF NOT EXISTS 2. lock migration table so concurrent migrations are serialized Considered submitting a PR to refinery with these two fixes, but this simple change was non trivial since they support multiple async/sync database drivers
serprex
added a commit
that referenced
this pull request
Dec 29, 2023
Currently server_tests must be run with --test-threads=1 because of two things: 1. port collision 2. concurrent migrations failing I explored fixing these in #926. Ports are easily solved, but migrations are a pain This migration code works around concurrency with two changes from refinery: 1. ignore unique constraint violation from CREATE TABLE IF NOT EXISTS 2. lock migration table so concurrent migrations are serialized Considered submitting a PR to refinery with these two fixes, but this simple change was non trivial since they support multiple async/sync database drivers
serprex
added a commit
that referenced
this pull request
Dec 29, 2023
Currently server_tests must be run with --test-threads=1 because of two things: 1. port collision 2. concurrent migrations failing I explored fixing these in #926. Ports are easily solved, but migrations are a pain This migration code works around concurrency with two changes from refinery: 1. ignore unique constraint violation from CREATE TABLE IF NOT EXISTS 2. lock migration table so concurrent migrations are serialized Considered submitting a PR to refinery with these two fixes, but this simple change was non trivial since they support multiple async/sync database drivers
serprex
added a commit
that referenced
this pull request
Dec 29, 2023
Currently server_tests must be run with --test-threads=1 because of two things: 1. port collision 2. concurrent migrations failing I explored fixing these in #926. Ports are easily solved, but migrations are a pain This migration code works around concurrency with two changes from refinery: 1. ignore unique constraint violation from CREATE TABLE IF NOT EXISTS 2. lock migration table so concurrent migrations are serialized Considered submitting a PR to refinery with these two fixes, but this simple change was non trivial since they support multiple async/sync database drivers
serprex
added a commit
that referenced
this pull request
Dec 29, 2023
Currently server_tests must be run with --test-threads=1 because of two things: 1. port collision 2. concurrent migrations failing I explored fixing these in #926. Ports are easily solved, but migrations are a pain This migration code works around concurrency with two changes from refinery: 1. ignore unique constraint violation from CREATE TABLE IF NOT EXISTS 2. lock migration table so concurrent migrations are serialized Considered submitting a PR to refinery with these two fixes, but this simple change was non trivial since they support multiple async/sync database drivers
serprex
added a commit
that referenced
this pull request
Dec 29, 2023
Currently server_tests must be run with --test-threads=1 because of two things: 1. port collision 2. concurrent migrations failing I explored fixing these in #926. Ports are easily solved, but migrations are a pain This migration code works around concurrency with two changes from refinery: 1. ignore unique constraint violation from CREATE TABLE IF NOT EXISTS 2. lock migration table so concurrent migrations are serialized Considered submitting a PR to refinery with these two fixes, but this simple change was non trivial since they support multiple async/sync database drivers
Currently server_tests must be run with --test-threads=1 because of two things: 1. port collision 2. concurrent migrations failing I explored fixing these in #926. Ports are easily solved, but migrations are a pain This migration code works around concurrency with two changes from refinery: 1. ignore unique constraint violation from CREATE TABLE IF NOT EXISTS 2. lock migration table so concurrent migrations are serialized Considered submitting a PR to refinery with these two fixes, but this simple change was non trivial since they support multiple async/sync database drivers
…block rest of transaction
serprex
force-pushed
the
mt-cargo-test
branch
from
aff9d3c to
2b98131
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of silly fixing this right after reducing nexus CI down to 2 cores,
but this'll avoid new hires hitting this error when onboarding like I did