Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlserver: port away from testify/suite #928

Merged
merged 1 commit into from
Dec 29, 2023
Merged

sqlserver: port away from testify/suite #928

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
105 changes: 51 additions & 54 deletions flow/e2e/sqlserver/qrep_flow_sqlserver_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,88 +5,85 @@ import (
"fmt"
"log/slog"
"os"
"strings"
"testing"
"time"

"github.com/PeerDB-io/peer-flow/e2e"
"github.com/PeerDB-io/peer-flow/e2eshared"
"github.com/PeerDB-io/peer-flow/generated/protos"
"github.com/PeerDB-io/peer-flow/model"
"github.com/PeerDB-io/peer-flow/model/qvalue"
"github.com/PeerDB-io/peer-flow/shared"
"github.com/jackc/pgx/v5/pgtype"
"github.com/jackc/pgx/v5/pgxpool"
"github.com/joho/godotenv"

"github.com/stretchr/testify/require"
"github.com/stretchr/testify/suite"
"go.temporal.io/sdk/testsuite"
"github.com/ysmood/got"
)

const sqlserverSuffix = "sqlserver"

type PeerFlowE2ETestSuiteSQLServer struct {
suite.Suite
testsuite.WorkflowTestSuite
got.G
t *testing.T

pool *pgxpool.Pool
sqlsHelper *SQLServerHelper
suffix string
}

func TestCDCFlowE2ETestSuiteSQLServer(t *testing.T) {
suite.Run(t, new(PeerFlowE2ETestSuiteSQLServer))
}

// setup sql server connection
func (s *PeerFlowE2ETestSuiteSQLServer) setupSQLServer() {
env := os.Getenv("ENABLE_SQLSERVER_TESTS")
if env != "true" {
s.sqlsHelper = nil
return
}
e2eshared.GotSuite(t, SetupSuite, func(s PeerFlowE2ETestSuiteSQLServer) {
err := e2e.TearDownPostgres(s.pool, s.suffix)
require.NoError(s.t, err)

sqlsHelper, err := NewSQLServerHelper("test_sqlserver_peer")
require.NoError(s.T(), err)
s.sqlsHelper = sqlsHelper
if s.sqlsHelper != nil {
err = s.sqlsHelper.CleanUp()
require.NoError(s.t, err)
}
})
}

func (s *PeerFlowE2ETestSuiteSQLServer) SetupSuite() {
func SetupSuite(t *testing.T, g got.G) PeerFlowE2ETestSuiteSQLServer {
t.Helper()

err := godotenv.Load()
if err != nil {
// it's okay if the .env file is not present
// we will use the default values
slog.Info("Unable to load .env file, using default values from env")
}

pool, err := e2e.SetupPostgres(sqlserverSuffix)
if err != nil || pool == nil {
s.Fail("failed to setup postgres", err)
suffix := "sqls_" + strings.ToLower(shared.RandomString(8))
pool, err := e2e.SetupPostgres(suffix)
if err != nil {
require.NoError(t, err)
}
s.pool = pool

s.setupSQLServer()
}

// Implement TearDownAllSuite interface to tear down the test suite
func (s *PeerFlowE2ETestSuiteSQLServer) TearDownSuite() {
err := e2e.TearDownPostgres(s.pool, sqlserverSuffix)
if err != nil {
s.Fail("failed to drop Postgres schema", err)
var sqlsHelper *SQLServerHelper
env := os.Getenv("ENABLE_SQLSERVER_TESTS")
if env != "true" {
sqlsHelper = nil
} else {
sqlsHelper, err = NewSQLServerHelper("test_sqlserver_peer")
require.NoError(t, err)
}

if s.sqlsHelper != nil {
err = s.sqlsHelper.CleanUp()
if err != nil {
s.Fail("failed to clean up sqlserver", err)
}
return PeerFlowE2ETestSuiteSQLServer{
G: g,
t: t,
pool: pool,
sqlsHelper: sqlsHelper,
suffix: suffix,
}
}

func (s *PeerFlowE2ETestSuiteSQLServer) setupSQLServerTable(tableName string) {
func (s PeerFlowE2ETestSuiteSQLServer) setupSQLServerTable(tableName string) {
schema := getSimpleTableSchema()
err := s.sqlsHelper.CreateTable(schema, tableName)
require.NoError(s.T(), err)
require.NoError(s.t, err)
}

func (s *PeerFlowE2ETestSuiteSQLServer) insertRowsIntoSQLServerTable(tableName string, numRows int) {
func (s PeerFlowE2ETestSuiteSQLServer) insertRowsIntoSQLServerTable(tableName string, numRows int) {
schemaQualified := fmt.Sprintf("%s.%s", s.sqlsHelper.SchemaName, tableName)
for i := 0; i < numRows; i++ {
params := make(map[string]interface{})
Expand All @@ -101,20 +98,20 @@ func (s *PeerFlowE2ETestSuiteSQLServer) insertRowsIntoSQLServerTable(tableName s
params,
)

require.NoError(s.T(), err)
require.NoError(s.t, err)
}
}

func (s *PeerFlowE2ETestSuiteSQLServer) setupPGDestinationTable(tableName string) {
func (s PeerFlowE2ETestSuiteSQLServer) setupPGDestinationTable(tableName string) {
ctx := context.Background()

_, err := s.pool.Exec(ctx, fmt.Sprintf("DROP TABLE IF EXISTS e2e_test_%s.%s", sqlserverSuffix, tableName))
require.NoError(s.T(), err)
_, err := s.pool.Exec(ctx, fmt.Sprintf("DROP TABLE IF EXISTS e2e_test_%s.%s", s.suffix, tableName))
require.NoError(s.t, err)

_, err = s.pool.Exec(ctx,
fmt.Sprintf("CREATE TABLE e2e_test_%s.%s (id TEXT, card_id TEXT, v_from TIMESTAMP, price NUMERIC, status INT)",
sqlserverSuffix, tableName))
require.NoError(s.T(), err)
s.suffix, tableName))
require.NoError(s.t, err)
}

func getSimpleTableSchema() *model.QRecordSchema {
Expand All @@ -129,13 +126,13 @@ func getSimpleTableSchema() *model.QRecordSchema {
}
}

func (s *PeerFlowE2ETestSuiteSQLServer) Test_Complete_QRep_Flow_SqlServer_Append() {
func (s PeerFlowE2ETestSuiteSQLServer) Test_Complete_QRep_Flow_SqlServer_Append() {
if s.sqlsHelper == nil {
s.T().Skip("Skipping SQL Server test")
s.t.Skip("Skipping SQL Server test")
}

env := s.NewTestWorkflowEnvironment()
e2e.RegisterWorkflowsAndActivities(s.T(), env)
env := e2e.NewTemporalTestWorkflowEnvironment()
e2e.RegisterWorkflowsAndActivities(s.t, env)

numRows := 10
tblName := "test_qrep_flow_avro_ss_append"
Expand All @@ -145,7 +142,7 @@ func (s *PeerFlowE2ETestSuiteSQLServer) Test_Complete_QRep_Flow_SqlServer_Append
s.insertRowsIntoSQLServerTable(tblName, numRows)

s.setupPGDestinationTable(tblName)
dstTableName := fmt.Sprintf("e2e_test_%s.%s", sqlserverSuffix, tblName)
dstTableName := fmt.Sprintf("e2e_test_%s.%s", s.suffix, tblName)

query := fmt.Sprintf("SELECT * FROM %s.%s WHERE v_from BETWEEN {{.start}} AND {{.end}}",
s.sqlsHelper.SchemaName, tblName)
Expand All @@ -172,13 +169,13 @@ func (s *PeerFlowE2ETestSuiteSQLServer) Test_Complete_QRep_Flow_SqlServer_Append
s.True(env.IsWorkflowCompleted())

err := env.GetWorkflowError()
s.NoError(err)
require.NoError(s.t, err)

// Verify that the destination table has the same number of rows as the source table
var numRowsInDest pgtype.Int8
countQuery := fmt.Sprintf("SELECT COUNT(*) FROM %s", dstTableName)
err = s.pool.QueryRow(context.Background(), countQuery).Scan(&numRowsInDest)
s.NoError(err)
require.NoError(s.t, err)

s.Equal(numRows, int(numRowsInDest.Int64))
}