Retry when WAL segment has not been found #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
reviewed
Dec 29, 2023
[Debezium](https://github.com/debezium/debezium/blob/db0cfea550308e7386413db25115d531a4c0a61c/debezium-connector-postgres/src/main/java/io/debezium/connector/postgresql/connection/PostgresReplicationConnection.java#L584) also does something similar. Awaiting confirmation from Postgres experts on this but so far what we have seen from the field indicates that this error is OK. This PR also does some minor refactors and cleaning up of error messages that looked very similar.
iskakaushik
force-pushed
the
retry-wal
branch
from
bbf04be to
839af7b
Compare
serprex
approved these changes
Dec 29, 2023
|
can we also log the segment that is erroring? |
it's getting logged higher up in the stack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debezium also does something similar. Awaiting confirmation from Postgres experts on this but so far what we have seen from the field indicates that this error is OK.
This PR also does some minor refactors and cleaning up of error messages that looked very similar.