Maintain column ordering #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskakaushik
reviewed
Dec 29, 2023
|
also adding a test would be beneficial here IMO |
serprex
force-pushed
the
ordered-columns
branch
from
d2ae3b1 to
4ff4d1e
Compare
|
already being tested by updated tests, there was initially a failure because I hadn't updated getting schema from snowflake to maintain column order |
iskakaushik
approved these changes
Dec 30, 2023
|
@serprex I did functional testing for PG, BQ and SF. Looks good! |
saisrirampur
approved these changes
Dec 30, 2023
Go maps are not ordered maps, ie iterating a map has non determinstic order This is causes us to lose ordering info when using using TableSchema.Columns Instead store columns as two arrays of column names & column types, which is used when TableSchema.Columns is nil This way we're backwards compatible while new mirrors will have correct ordering
serprex
force-pushed
the
ordered-columns
branch
from
5e35513 to
5933443
Compare
serprex
added a commit
that referenced
this pull request
Dec 31, 2023
Go maps are not ordered maps, ie iterating a map has non determinstic order This is causes us to lose ordering info when using using TableSchema.Columns Instead store columns as two arrays of column names & column types, which is used when TableSchema.Columns is nil This way we're backwards compatible while new mirrors will have correct ordering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go maps are not ordered maps,
ie iterating a map has non determinstic order
This is causes us to lose ordering info when using using TableSchema.Columns
Instead store columns as two arrays of column names & column types,
which is used when TableSchema.Columns is nil
This way we're backwards compatible while new mirrors will have correct ordering
Fixes #888