e2e/s3: remove use of testify/suite #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
force-pushed
the
s3-remove-testify-suite
branch
from
52b4ae1 to
ee1d078
Compare
Remove setupS3, calling it after setup leaked initial s3Helper, instead test creates helper & defers cleanup within test using
serprex
force-pushed
the
s3-remove-testify-suite
branch
from
2b902bd to
dbb036e
Compare
Amogh-Bharadwaj
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling setupS3 after setup leaked initial s3Helper
Run test suite twice: once with s3, once with gcs