Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fixes default for some params #959

Merged
merged 1 commit into from
Jan 2, 2024
Merged

UI: Fixes default for some params #959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/app/mirrors/create/helpers/cdc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ export const cdcSettings: MirrorSetting[] = [
softDelete: (value as boolean) || false,
})),
tips: 'Allows you to mark some records as deleted without actual erasure from the database',
default: 'SQL',
default: false,
type: 'switch',
},
{
Expand Down
2 changes: 1 addition & 1 deletion ui/app/mirrors/create/helpers/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export const blankQRepSetting = {
syncMode: 0,
batchSizeInt: 0,
batchDurationSeconds: 0,
maxParallelWorkers: 1,
maxParallelWorkers: 4,
waitBetweenBatchesSeconds: 30,
writeMode: undefined,
stagingPath: '',
Expand Down
8 changes: 4 additions & 4 deletions ui/app/mirrors/create/helpers/qrep.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export const qrepSettings: MirrorSetting[] = [
...curr,
maxParallelWorkers: parseInt(value as string, 10) || 4,
})),
tips: 'PeerDB spins up parallel threads for each partition. This setting controls the number of partitions to sync in parallel. The default value is 8.',
tips: 'PeerDB spins up parallel threads for each partition. This setting controls the number of partitions to sync in parallel. The default value is 4.',
default: '4',
type: 'number',
},
Expand Down Expand Up @@ -131,10 +131,10 @@ export const qrepSettings: MirrorSetting[] = [
stateHandler: (value, setter) =>
setter((curr: QRepConfig) => ({
...curr,
waitBetweenBatchesSeconds: parseInt(value as string, 10) || 5,
waitBetweenBatchesSeconds: parseInt(value as string, 10) || 30,
})),
tips: 'Time to wait (in seconds) between getting partitions to process.',
default: 5,
tips: 'Time to wait (in seconds) between getting partitions to process. The default is 30 seconds',
default: 30,
type: 'number',
},
// {
Expand Down
Loading