tests: avoid require in non-initial go routines #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amogh-Bharadwaj
approved these changes
Jan 3, 2024
docs: > FailNow must be called from the goroutine running the test or benchmark function, > not from other goroutines created during the test This would cause workflow to hang if it was waiting on goroutine, so introduce helper functions which: 1. Check assertion 2. Log failure & mark test failed 3. Cancel workflow 4. Abort goroutine A followup PR will fix calls to compareTableContents after #967 merges too
serprex
force-pushed
the
no-require-in-goroutine
branch
from
78543e6 to
7b26d90
Compare
serprex
added a commit
that referenced
this pull request
Jan 3, 2024
Split the two use cases into two functions, e2e.RequireEqualTables & e2e.EnvEqualTables Which uses interfaces to share code between Followup for #977
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pkg.go.dev/testing#T.FailNow
This would cause workflow to hang if it was waiting on goroutine, so introduce helper functions which:
A followup PR will fix calls to compareTableContents