Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/axelar proxy #118

Merged
merged 15 commits into from
Jun 5, 2023
Merged

Feat/axelar proxy #118

merged 15 commits into from
Jun 5, 2023

Conversation

crispymangoes
Copy link
Collaborator

No description provided.

src/AxelarProxy.sol Show resolved Hide resolved
src/AxelarProxy.sol Show resolved Hide resolved
src/AxelarProxy.sol Outdated Show resolved Hide resolved
@0xEinCodes
Copy link
Contributor

In general looks good to move forward to audit. I made some small suggestions and had questions that would be great to get clarity on before wrapping it up.

That all said, I think there are the risk vectors associated to what the toggle was supposed to do in AxelarProxy.sol. What is the resolution process if Axelar is hacked? I suppose Cellars fully relying on msg communications using Axelar would be in withdrawOnly mode where users could withdraw in those networks. Obviously that is not ideal for users though.

I think Resolution processes should be discussed openly in an issue as this feature is developed and deployed.


As well, please confirm that I am understanding this PR details (might be just that I am newer to the Axelar setup since we're both working on a multitude of different things nowadays!)

  • AxelarProxy.sol: the proxy contract itself that will be deployed on alternative chains. It is the touch point for us, and showcases that we can set things up to execute various actions in an alternative chain.
  • DeployProxy.s.sol: the deployment script just testing out deployment of the Proxy contract.
  • MockSommelier.sol & SendMessageToArbitrum.s.sol —> together tests out how Sommelier (Steward) would actually make the call with Axelar.
    • MockSommelier.sol: showcases how Sommelier (Steward) would prepare data and pass it along to Axelar gateway, ultimately to a proxy contract on an alternative chain.
    • SendMessageToArbitrum.s.sol: simply the script to carry out this test.
      • Question: Sommelier determines what the payload will carry out, and the destination chain Proxy contract will check with the Axelar Gateway if a certain payload is an approved action right? If so, how does that all work, this is something that needs to be well documented / our resources need to point to it so others can understand this when they want to work with the Sommelier protocol.
        - On the Sommelier side, it would be regular $SOMM governance dictating what is passed to be created on these alt chains, and then further coordination/whitelisting with Axelar would be needed I assume?

Copy link
Contributor

@0xEinCodes 0xEinCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed all of this and it is good to go to main and audit review.

@crispymangoes crispymangoes merged commit 17d8217 into main Jun 5, 2023
@crispymangoes crispymangoes deleted the feat/axelar-proxy branch June 5, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants