-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design, Develop, Test CompoundV3 Adaptors #147
Design, Develop, Test CompoundV3 Adaptors #147
Conversation
@crispymangoes -
|
logic contract, & start debt adaptor
@crispymangoes - Roughly wrote the remaining adaptors (Supply and Debt adaptors). Next step is to go over the key complication areas such as the following (some discussed):
|
Worked through all major discussion points brought up through development so far. Now working through compilation troubleshooting. Once that is done, if there is time we will move on to writing unit tests for the supply adaptors, but this may be postponed as outlined in the |
I am closing this branch as it has been continued and completed in PR #176 |
Core changes:
This PR encompasses the integration of CompoundV3 into Sommelier. It revolves around the development and testing of an adaptor (or adaptors) that includes features such as:
BaseAssets
to different Compound V3 lending markets.Collateral
to the calling Cellar's Compound V3 account.BaseAssets
to different Compound V3 lending markets.Current Design / TODOs
Currently doing (General):
CompoundV3ExtraLogic
CompoundV3CollateralAdaptor.sol
handles supplying 'Collateral` to a Cellar's lending market account / position.CompoundV3DebtAdaptor.sol
handles borrowingBaseAsset
(has to be coordinated with aCompoundV3CollateralAdaptor
position withcollateral
provided.CompoundLendingAdaptor.sol
handles lendingBaseAsset
to a respectiveCompoundMarket
.HealthFactorLogic.sol
type file providing helpers in calculating updated health factors.References