Feat/erc4626 share price oracle automation forwarder #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crispymangoes
deleted the
feat/erc4626-share-price-oracle-automation-forwarder
branch
0xEinCodes
reviewed
Oct 17, 2023
There was a problem hiding this comment.
All in all looks good to me. I noticed you commented out some test code in the LegacyCellarAdaptorForRye, may you expand on that? Also I have a couple clarification questions that I'm not too worried about:
- Interfaces are custom? I may have just missed this at a glance but it seems
getForwarderis not an interface function withinIRegistry.solfrom Chainlink for example. Forwarder== reverse proxy. Essentially it acts as a single address that any node can report to. Is this an alright interpretation? This would make sense that it has to be the one performingupkeepnow.
|
Yeah so Because of this the test is commented out. In the future we might completely remove this test, but for now it has been left commented out, so that it can be referenced. |
crispymangoes
added a commit
that referenced
this pull request
Oct 30, 2023
* Feat/pricing extensions erc4626 redstone eth curve ema (#148) * Create Redstone Eth pricing extension and add tests. * Create ERC4626 pricing extension and write test. * Create Curve EMA oracle extension * Work on CurveEMAExtension test * Add integration test with actual sweth eth feed * Update outdated comment * Create redstone Eth deploy script, and script for deploying V1 Auotmation Upkeeps * Fix script error using the wrong func selector * Feat/erc4626 share price oracle automation forwarder (#149) * Work out how to integrate forwarder address * Setup share price oracle to work with new forwarder * Integreate new forwarder logic for share price oracle * Update comment * Update comments in pricing extensions, move interface, and rename `testStrategist` to `devStrategist` so it is not included in tests * feat/ Write Aura Protocol Integrations Smart Contracts (#141) * Write README for Aura integration to discuss around * Write rough AuraExtrasAdaptor.sol && questions in md files * Write CellarAdaptorWithAura.t.sol pseudo-code * Continue working on aura tests w/ cellar adaptor * Finish 1st stateless fuzz tests w/ Aura Positions * Start drafting up ERC4626Adaptor.sol * Start writing new AuraERC4626 Adaptor & tests * Write AuraERC4626Adaptor tests w/ new ERC4626Adaptor.sol * Replace old aura test files w/ new auraERC4626 tests * Reformat ERC4626Adaptor.sol to use ERC4626 vs Cellar * Delete prelim md aura adaptor docs & finalize tests * Make minor change requests as per PR Review #141 * Create relevant tests w/ Cellar & ERC4626Adaptor & move ERC4626Adaptor.sol * Make changes as per PR #141 Review * Check, then remove console logs from AuraERC4626AdaptorTest * Reformat AdaptorHelperFunctions.sol * Remove TODO comments in AuraERC4626Adaptor.sol * Make adjustments to Fraxlend Adaptors as per Feedback from Strategists (#150) * Add maxAvailable() to removeCollateral() & fix DebtFTokenAdaptor w/ toBorrowShares() * Add more Fraxlend removeCollateral tests w/ type(uint256).max * Resolve most of fraxlend adaptors stateless fuzzing * Add test showing sFRAX integration is supported using existing CellarAdaptor (#151) * Fix/macro audit 12 (#152) * Fix M1 * Fix L2 * Fix L1 * Fix M2 --------- Co-authored-by: 0xEinCodes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.