cbETH-adr

[henrio123]

The address for cbETH on the Optimism chain contains a typo with an extra leading zero.

Summary by CodeRabbit

• Bug Fixes
  • Corrected the Ethereum address format for the cbETH token under the OPTIMISM chain, ensuring proper functionality.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sommelier-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 28, 2024 11:21am

[coderabbitai]

Walkthrough

The changes involve a correction to the tokenConfig array in the src/data/tokenConfig.ts file, specifically updating the Ethereum address format for the token symbol cbETH under the OPTIMISM chain. The address was modified from an invalid format to a valid Ethereum address format, ensuring compliance with expected standards without altering any other logic or functionality in the file.

Changes

File Path	Change Summary
src/data/tokenConfig.ts	Updated token address for cbETH from 00xadDb6A0412DE1BA0F936DCaeb8Aaa24578dcF3B2 to 0xadDb6A0412DE1BA0F936DCaeb8Aaa24578dcF3B2.

Suggested reviewers

• zmanian
• 51N84D
• philipjames44
• poldsam
• josephterrigno
• otsalex

🐰 In the meadow, where tokens play,
A little change brightens the day.
From wrong to right, the address gleams,
For cbETH, it fulfills our dreams!
Hopping along, we celebrate,
Valid formats make us great! 🌼

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between ba35aca and 3c51d33.

📒 Files selected for processing (1)

• src/data/tokenConfig.ts (1 hunks)

🔇 Additional comments (2)

src/data/tokenConfig.ts (2)

256-256: LGTM! Address format corrected.

The Ethereum address format has been properly fixed by removing the extra leading zero.

---

Line range hint 677-677: Verify if cbETH should be added to acceptedOPTDepositTokens.

While the address format is now correct, I notice that cbETH is not included in the acceptedOPTDepositTokens array. Please verify if this is intentional or if it should be added to the accepted tokens list for Optimism.

✅ Verification successful

cbETH exclusion from Optimism deposits appears intentional

The verification shows that while cbETH is configured for Optimism (with address 0xadDb6A0412DE1BA0F936DCaeb8Aaa24578dcF3B2), it is intentionally not included in the acceptedOPTDepositTokens array. This is consistent with the current system design where Optimism only accepts a specific subset of tokens ['WETH', 'wstETH', 'rETH', 'ETH'] for deposits. Adding cbETH to the accepted tokens list would be a separate feature enhancement beyond the scope of this address typo fix.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if cbETH is used elsewhere in the codebase for Optimism
echo "Searching for cbETH usage with Optimism..."
rg -i "cbeth.*optimism" --type ts

Length of output: 130

---

Script:

#!/bin/bash
# Let's check for cbETH configuration and usage more broadly
echo "Checking cbETH configuration..."
rg -i "cbeth" --type ts -A 5

# Also check the accepted tokens configuration
echo -e "\nChecking accepted tokens configuration..."
rg "acceptedOPTDepositTokens" --type ts -A 5

Length of output: 5094

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.