Fix unit tests and more SDK v0.47 upgrade changes

[cbrit]

Summary by CodeRabbit

• New Features

  • Added support for autocli and reflection services in the application.

• Tests

  • Updated test encoding configurations across various modules to enhance consistency and reliability in testing scenarios.
  • Streamlined TestAuction function to improve test execution time by removing unnecessary dependencies.
  • Improved error handling and return types in the integration tests for better control flow and robustness.

• Refactor

  • Changed return types of ProposalContents method in multiple modules to improve type accuracy and consistency.
  • Simplified genesis state configuration by removing unnecessary parameter initializations.

[coderabbitai]

Walkthrough

The modifications enhance the application's functionality by integrating new services in app/app.go, improving encoding configurations in test files, and enhancing error handling in integration tests. Key updates include registering query servers for autocli and reflection services, standardizing the return type of ProposalContents methods across various modules, and implementing more robust error management in the getCurrentHeight function.

Changes

File Path	Change Summary
app/app.go	Added registrations for autocli and reflection services using runtimeservices. Updated parameters keeper configuration by removing the key table for the governance module.
.../auction/client/cli/tx_test.go .../axelarcork/client/cli/tx_test.go .../cork/client/cli/tx_test.go	Replaced testutil.TestEncodingConfig() with moduletestutil.MakeTestEncodingConfig() in multiple test functions related to proposal parsing.
.../auction/module.go .../axelarcork/module.go .../cellarfees/module.go .../cork/module.go .../incentives/module.go .../pubsub/module.go	Updated the return type of ProposalContents from []sim.WeightedProposalContent to []sim.WeightedProposalMsg in multiple modules.
integration_tests/auction_test.go	Streamlined the TestAuction function by removing unnecessary retrieval of node status and block height.
integration_tests/setup_test.go	Simplified genesis state configuration by removing initialization of proposer reward parameters.
integration_tests/incentives_test.go	Enhanced the getCurrentHeight function to return an int64 and an error, improving error handling and robustness.

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0326674 and b0d8f9d.

Files selected for processing (1)

• integration_tests/incentives_test.go (1 hunks)

Additional comments not posted (2)

integration_tests/incentives_test.go (2)

230-238: LGTM!

The function correctly handles the error return value from getCurrentHeight.

---

213-222: LGTM! But verify the function usage in the codebase.

The code changes are approved.

However, ensure that all function calls to getCurrentHeight handle the new error return value appropriately.

Verification successful

---

All usages of getCurrentHeight handle the new error return value appropriately.

The function calls to getCurrentHeight have been verified, and they correctly handle the new error return value.

• integration_tests/incentives_test.go:
  • Lines: 213-222
  • Lines: 226-235

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all function calls to `getCurrentHeight` handle the new error return value.

# Test: Search for the function usage. Expect: All usages handle the error return value.
rg --type go -A 5 $'getCurrentHeight'

Length of output: 1254

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

[coderabbitai]

Consider handling the error without panicking, perhaps by logging the error and continuing with a degraded service mode if possible.

- panic(err)
+ log.Errorf("Failed to create reflection service: %v", err)
+ // Continue with degraded service mode or other error handling strategy

---

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

	reflectionSvc, err := runtimeservices.NewReflectionService()
	if err != nil {
	panic(err)
	}
	reflectionv1.RegisterReflectionServiceServer(app.GRPCQueryRouter(), reflectionSvc)
	reflectionSvc, err := runtimeservices.NewReflectionService()
	if err != nil {
	log.Errorf("Failed to create reflection service: %v", err)
	// Continue with degraded service mode or other error handling strategy
	}
	reflectionv1.RegisterReflectionServiceServer(app.GRPCQueryRouter(), reflectionSvc)