Implement error logging channel + basic tests #2
Conversation
|
Many of the tests are failing. I see that you have mentioned many TODOs. Merging these tests without getting them to a working condition first seems like a terrible practice. We can either split the working parts and the non-working parts and merge only the former, or I can make the configuration management changes you require, and you can then complete your TODOs. |
|
Also, it would be a bad idea to force the application to handle logging errors. Another idea I was considering was letting the application provide a callback function that would be invoked when an error arises. This approach would reduce the rigidity enforced by the logging library and provide more flexibility to the application. If the application wants, it could transmit the errors to a channel, or if needed, perform an immediate shutdown. What are your thoughts on this? |
Tests are currently broken, I can rebase them out if desired