Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include <algorithm> for std::transform #74

Merged

Conversation

ellert
Copy link
Contributor

@ellert ellert commented Dec 31, 2024

/builddir/build/BUILD/xrootd-s3-http-0.1.8-build/xrootd-s3-http-0.1.8/test/s3_unit_tests.cc: In member function ‘virtual void AmazonS3SendMultipartPartLowercase::modifyResponse(std::string&)’:
/builddir/build/BUILD/xrootd-s3-http-0.1.8-build/xrootd-s3-http-0.1.8/test/s3_unit_tests.cc:589:22: error: ‘transform’ is not a member of ‘std’
  589 |                 std::transform(resp.begin(), resp.end(), resp.begin(),
      |                      ^~~~~~~~~
gmake[2]: *** [test/CMakeFiles/s3-unit-test.dir/build.make:82: test/CMakeFiles/s3-unit-test.dir/s3_unit_tests.cc.o] Error 1
gmake[2]: Leaving directory '/builddir/build/BUILD/xrootd-s3-http-0.1.8-build/xrootd-s3-http-0.1.8/redhat-linux-build'
gmake[1]: *** [CMakeFiles/Makefile2:359: test/CMakeFiles/s3-unit-test.dir/all] Error 2
gmake[1]: *** Waiting for unfinished jobs....

Copy link
Collaborator

@bbockelm bbockelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bbockelm bbockelm merged commit f978980 into PelicanPlatform:main Jan 2, 2025
3 checks passed
@bbockelm
Copy link
Collaborator

bbockelm commented Jan 2, 2025

Thanks @ellert!

What platform were you running that hit this issue? Your submission is obviously correct from a C++ point of view but this indicates a deficiency in our CI (which only hits ubuntu-24.04).

Brian

@ellert ellert deleted the include-algorithm-std-transform branch January 10, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants