Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create OpenLink for the pinguinmod extensions #85

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SergeyScratch
Copy link

there are two blocks in the extension, the first block opens the link in a new tab, the second block opens the link in a separate window

there are two blocks in the extension, the first block opens the link in a new tab, the second block opens the link in a separate window
Copy link

vercel bot commented Dec 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
penguinmod-extensions-gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2023 3:01pm

@SharkPool-SP
Copy link
Collaborator

So.... network extension. That already exists

@TheShovel
Copy link
Collaborator

This could be a security risk. You need to use the security manager before opening any page.

@RedMan13
Copy link
Contributor

so like, extensions are meant to be .js files

@JeremyGamer13
Copy link
Member

  • file should end with .js
  • use the Promise result of Scratch.canOpenWindow() to make sure you can actually open the new tab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants