Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added credential and host DB for LDAP protocol #527

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lap1nou
Copy link
Contributor

@lap1nou lap1nou commented Dec 30, 2024

Description

Greeting,

I remarked that credential and host found from the LDAP protocol were not added to the NXC database. This PR aim to fix that, it is basically a copy paste of what is done in the SMB protocol with a few changes here and there.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I ran end-to-end test, only a few fails but doesn't seems to be related to this changes, I also tested to check the DB to see if it was populated for the LDAP protocol.

Screenshots (if appropriate):

N/A

Checklist:

  • I have ran Ruff against my changes (via poetry: poetry run python -m ruff check . --preview, use --fix to automatically fix what it can)
  • I have added or updated the tests/e2e_commands.txt file if necessary
  • New and existing e2e tests pass locally with my changes
  • My code follows the style guidelines of this project (should be covered by Ruff above)
  • If reliant on third party dependencies, such as Impacket, dploot, lsassy, etc, I have linked the relevant PRs in those projects
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (PR here: https://github.com/Pennyw0rth/NetExec-Wiki)

Signed-off-by: lapinou <[email protected]>
Signed-off-by: lapinou <[email protected]>
@NeffIsBack
Copy link
Contributor

Hi, thanks for your work!
Could you also implement the get_credentials function, so that ldap -id xy or ldap -id all is working?

@NeffIsBack NeffIsBack added the enhancement New feature or request label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants