Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing with earlier go version #2681

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
testing with earlier go version
  • Loading branch information
kaushikpuneet07 committed Jun 9, 2024
commit ff42d6c654358d391c716c196a454d73485616f2
4 changes: 2 additions & 2 deletions proxysql/build-binary-proxysql
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ elif [ -f /usr/bin/apt ]; then
fi

# We need to use golang version >= 1.21. Downloading golang from tarball to ensure each platform uses the same version.
sudo wget https://go.dev/dl/go1.21.9.linux-amd64.tar.gz
sudo wget https://go.dev/dl/go1.17.7.linux-amd64.tar.gz
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why such old golang version? there are a lot of cves in it


# /usr/local is the default path included in the $PATH variable. Using any other custom installation path will not work
# Example:
Expand All @@ -64,7 +64,7 @@ sudo wget https://go.dev/dl/go1.21.9.linux-amd64.tar.gz
#
# The above method will not work. This is because the value of $PATH is not preserved/passed on to the child scipt from the parent script
# Hence using the default $PATH that is available to every new session (both parent and child script)
sudo tar -C /usr/local/ -xzf go1.21.9.linux-amd64.tar.gz
sudo tar -C /usr/local/ -xzf go1.17.7.linux-amd64.tar.gz
sudo cp /usr/local/go/bin/go /usr/local/bin/go
if [ -f /usr/bin/yum ]; then
RHEL=$(rpm --eval %rhel)
Expand Down
2 changes: 1 addition & 1 deletion proxysql/qa-proxysql2-pipeline.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ pipeline {
script {
currentBuild.displayName = "#${BUILD_NUMBER}-${params.BRANCH}-${params.DOCKER_OS}-${params.CMAKE_BUILD_TYPE}-${params.PXC_VERSION}"
}
git branch: 'master', url: 'https://github.com/Percona-Lab/jenkins-pipelines'
git branch: 'check-go', url: 'https://github.com/kaushikpuneet07/jenkins-pipelines'
echo 'Checkout ProxySQL sources'
sh '''
# sudo is needed for better node recovery after compilation failure
Expand Down