Extend 'Set' to conform to protocol 'JSONConvertible' #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| var first = true | ||
| for v in self { | ||
| if !first { | ||
| s.append(",") |
There was a problem hiding this comment.
Is there a reason you're using this for loop instead of joined(separator:)? https://developer.apple.com/documentation/swift/array/1690077-joined
There was a problem hiding this comment.
Hi Alex, I went with the same (existing) approach used in Array's extension. My pull request was intended to let others know that Set is not conforming to protocol JSONConvertible, as stated in the JIRA issue I created (ISS-556). Feel free to implement it in any other (better) way. Thanks for looking into it!
There was a problem hiding this comment.
please adding a test script as well to prove this work. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setshould also conform to protocolJSONConvertible.