switch from clear prototypes to ambiguous ones in signature testing

Under signature regime, most prototypes are just complete nonsense, and we care about testing whether the switches work. As such, using a form that can be both a prototype and a signature helps test better.
Perl-Critic · Nov 19, 2024 · 3d23b3a · 3d23b3a
1 parent a23005d
commit 3d23b3a
Showing 1 changed file with 18 additions and 18 deletions.
diff --git a/t/feature_tracking.t b/t/feature_tracking.t
@@ -20,15 +20,15 @@ sub test_document;
 FEATURE_TRACKING: {
 	test_document
 	  <<'END_PERL',
-		sub meep(&$) {}
+		sub meep($) {}
 		use 5.035;
 		sub marp($left, $right) {}
 END_PERL
 	  [
-		'PPI::Statement::Sub'       => 'sub meep(&$) {}',
+		'PPI::Statement::Sub'       => 'sub meep($) {}',
 		'PPI::Token::Word'          => 'sub',
 		'PPI::Token::Word'          => 'meep',
-		'PPI::Token::Prototype'     => '(&$)',
+		'PPI::Token::Prototype'     => '($)',
 		'PPI::Structure::Block'     => '{}',
 		'PPI::Token::Structure'     => '{',
 		'PPI::Token::Structure'     => '}',
@@ -51,14 +51,14 @@ DOCUMENT_FEATURES: {
 	test_document
 	  [ feature_mods => { signatures => 1 } ],
 	  <<'END_PERL',
-		sub meep(&$) {}
+		sub meep($) {}
 		sub marp($left, $right) {}
 END_PERL
 	  [
-		'PPI::Statement::Sub'   => 'sub meep(&$) {}',
+		'PPI::Statement::Sub'   => 'sub meep($) {}',
 		'PPI::Token::Word'      => 'sub',
 		'PPI::Token::Word'      => 'meep',
-		'PPI::Token::Signature' => '(&$)',
+		'PPI::Token::Signature' => '($)',
 		'PPI::Structure::Block' => '{}',
 		'PPI::Token::Structure' => '{',
 		'PPI::Token::Structure' => '}',
@@ -77,15 +77,15 @@ DISABLE_FEATURE: {
 	test_document
 	  [ feature_mods => { signatures => 1 } ],
 	  <<'END_PERL',
-		sub meep(&$) {}
+		sub meep($) {}
 		no feature 'signatures';
 		sub marp($left, $right) {}
 END_PERL
 	  [
-		'PPI::Statement::Sub'       => 'sub meep(&$) {}',
+		'PPI::Statement::Sub'       => 'sub meep($) {}',
 		'PPI::Token::Word'          => 'sub',
 		'PPI::Token::Word'          => 'meep',
-		'PPI::Token::Signature'     => '(&$)',
+		'PPI::Token::Signature'     => '($)',
 		'PPI::Structure::Block'     => '{}',
 		'PPI::Token::Structure'     => '{',
 		'PPI::Token::Structure'     => '}',
@@ -108,14 +108,14 @@ END_PERL
 PROTOTYPE_ATTR: {
 	test_document
 	  <<'END_PERL',
-		sub meep :prototype(&$) {}
+		sub meep :prototype($) {}
 END_PERL
 	  [
-		'PPI::Statement::Sub'   => 'sub meep :prototype(&$) {}',
+		'PPI::Statement::Sub'   => 'sub meep :prototype($) {}',
 		'PPI::Token::Word'      => 'sub',
 		'PPI::Token::Word'      => 'meep',
 		'PPI::Token::Operator'  => ':',
-		'PPI::Token::Attribute' => 'prototype(&$)',
+		'PPI::Token::Attribute' => 'prototype($)',
 		'PPI::Structure::Block' => '{}',
 		'PPI::Token::Structure' => '{',
 		'PPI::Token::Structure' => '}',
@@ -177,18 +177,18 @@ HOMEBREW_ARGS: {
 	  [ custom_feature_includes => { strEct => { signatures => 1 } } ],
 	  <<'END_PERL',
 		use strEct;
-		sub meep(&$) {}
+		sub meep($) {}
 		sub marp($left, $right) {}
 END_PERL
 	  [
 		'PPI::Statement::Include' => 'use strEct;',
 		'PPI::Token::Word'        => 'use',
 		'PPI::Token::Word'        => 'strEct',
 		'PPI::Token::Structure'   => ';',
-		'PPI::Statement::Sub'     => 'sub meep(&$) {}',
+		'PPI::Statement::Sub'     => 'sub meep($) {}',
 		'PPI::Token::Word'        => 'sub',
 		'PPI::Token::Word'        => 'meep',
-		'PPI::Token::Signature'   => '(&$)',
+		'PPI::Token::Signature'   => '($)',
 		'PPI::Structure::Block'   => '{}',
 		'PPI::Token::Structure'   => '{',
 		'PPI::Token::Structure'   => '}',
@@ -216,7 +216,7 @@ HOMEBREW_CB: {
 	  ],
 	  <<'END_PERL',
 		use strEct "sigg";
-		sub meep(&$) {}
+		sub meep($) {}
 		sub marp($left, $right) {}
 END_PERL
 	  [
@@ -225,10 +225,10 @@ END_PERL
 		'PPI::Token::Word'          => 'strEct',
 		'PPI::Token::Quote::Double' => '"sigg"',
 		'PPI::Token::Structure'     => ';',
-		'PPI::Statement::Sub'       => 'sub meep(&$) {}',
+		'PPI::Statement::Sub'       => 'sub meep($) {}',
 		'PPI::Token::Word'          => 'sub',
 		'PPI::Token::Word'          => 'meep',
-		'PPI::Token::Signature'     => '(&$)',
+		'PPI::Token::Signature'     => '($)',
 		'PPI::Structure::Block'     => '{}',
 		'PPI::Token::Structure'     => '{',
 		'PPI::Token::Structure'     => '}',