Regex engine diagnostics and style cleanups #22982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khwilliamson
approved these changes
Feb 10, 2025
mauke
reviewed
Feb 10, 2025
Noticed by mauke in #22978 I didn't make the change in that commit to keep it minimal for the purpose of fixing a bug, but the failed var should be a bool not an integer.
Add color support, and clean up the output to use hex, add word data, show the character for ASCII characters.
and add a bit of extra metadata to both. I used a cruder version of this to debug #22892
use "flags:" instead of "flags=" as this makes it easier to distinguish cases where we are debugging the value of flags versus assigning to it.
In some of my older patches I left hugged assignements, and sometimes I tightly hugged (in)equality operators, and sometime I did not. There is also some level of inconsistency with some other contributors. This patch tries to make all such cases consistent, with no hugging. No actual logic changes should be present in this patch.
demerphq
force-pushed
the
yves/reg_diag_and_style_cleanups
branch
from
08bde9f to
5407d3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch sequence primarily changes diagnostic output or makes style changes to remove artifacts from my older coding style.
The only non-debugging code this changes is to use a boolean for a variable that used to use an int and values of 1/0,
One part of the change enhances the TRIE and AHO-CORASICK diagnostics so they are consistent with each other and include a bit more information than they used to.
The other part reworks the style of assignment and (in)equality operators and a few other minor whitespace changes so that as much as possible the form used for an equivalency check is the same unhugged form everywhere.
This patch was motivated by some frustration I encountered while debugging #22892 and writing #22978