regcomp: handle cloning the rexc cleanup in the scope stack #23179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauke
approved these changes
Apr 18, 2025
Previous on Win32 this could cause a double-free of the RExC state if an emulated fork was done with the free of the state on the scope stack. Use a custom save type and prevent freeing in the cloned process to prevent the double-free. Fixes Perl#23022
388bf71 (ignoring Perl#23022 for now) ensured that the RExC_state and its controlled pointers were freed once and only once, regardless of whether re_op_compile() returned normally or threw an exception. Unfortunately that free could happen very later, surviving well beyond when the regexp was compiled. Add an ENTER/LEAVE pair to ensure the cleanup is done immediately on a normal return.
mauke
force-pushed
the
23022-pseudo-fork-rexc
branch
from
e7c6b0a to
c54f9ca
Compare
shawnlaffan
added a commit
to StrawberryPerl/Perl-Dist-Strawberry
that referenced
this pull request
Apr 22, 2025
These are adapted from Perl/perl5#23179 Differences are: 1. The perldelta update is removed as it is 5.42 specific. 2. scope_types.h has been regenerated as its patch section did not apply cleanly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous on Win32 this could cause a double-free of the RExC state if an emulated fork was done with the free of the state on the scope stack.
Use a custom save type and prevent freeing in the cloned process to prevent the double-free.
Fixes #23022