Fix bug in resolve_relationship_condition with sources with virtual columns #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the interface of resolve_relationship_condition was simplified, it contained a codepath exempting result objects from any checks of their get_columns() results. Keep the stringent check ( so that new code using this function will not assume questionable defaults going forward ), and instead fix all callsites where this condition might arise -- This commit fixes the bug revealed by downstream RapidApp test case in this commit: * vanstyn/RapidApp@c319a41904 Huge thanks to @ribasushi for identifing the needed code changes to address this once I was able to provide the failing test case in RapidApp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits needed to fix bug revealed by RapidApp test case in this commit:
Huge thanks to @ribasushi for identifing the needed code changes (namely
4734916) to fix the bug once I was able to provide the failing
test case in RapidApp