Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document missing logging hooks and format option; fix typo #1706

Closed
wants to merge 3 commits into from
Closed

Document missing logging hooks and format option; fix typo #1706

wants to merge 3 commits into from

Conversation

cromedome
Copy link
Contributor

Here are a couple of very small fixes: correcting a subtest name typo, and documenting a missing formatting option in the logger docs.

@cromedome cromedome changed the title Document missing logging format; fix typo Document missing logging format and logger hooks; fix typo Jan 2, 2024
@cromedome cromedome changed the title Document missing logging format and logger hooks; fix typo Document missing logging hooks and format option; fix typo Jan 2, 2024
@cromedome cromedome modified the milestone: Dancer2 1.0.0 Jan 2, 2024
yanick
yanick approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@yanick yanick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice!

SysPete
SysPete approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@SysPete SysPete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cromedome!

@cromedome cromedome closed this Jan 3, 2024
@cromedome cromedome deleted the docs/missing-log-info branch January 3, 2024 02:11
@cromedome
Copy link
Contributor Author

Merged, thanks!

cromedome pushed a commit that referenced this pull request Jul 18, 2024
v1.1.1
36bdd7a 
    [ BUG FIXES ]
    * GH #1712: Fix use of send_as in templates (Andy Beverley)

    [ ENHANCEMENTS ]
    * None

    [ DOCUMENTATION ]
    * PR #1706: Document missing logging hooks and log format option;
      fix typo in logging test (Jason A. Crome)

    [ DEPRECATED ]
    * None

    [ MISC ]
    * None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SysPete SysPete SysPete approved these changes

@yanick yanick yanick approved these changes

@xsawyerx xsawyerx Awaiting requested review from xsawyerx

@GeekRuthie GeekRuthie Awaiting requested review from GeekRuthie

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cromedome @yanick @SysPete