Fix unable to use send_as during template processing (#1712) #1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skington
reviewed
Jul 8, 2024
|
👍 from me. Will publish another release as soon as we get another +1 on this. |
yanick
approved these changes
Jul 13, 2024
|
Looks good to me, also! |
|
Merged, thanks! |
|
Fantastic, thanks all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the problems as described in #1712. Namely these are further issues subsequent to #1622 regarding unusual actions that take place during template rendering. This could be, for example, custom exception handling during failed template rendering, which result in plain text being sent back to the client instead of the template.