Add Module::Pluggable as a requirement, excluding broken versions #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Module::Pluggable added checks for unreadable files in v6.1 and v6.2. Those tests fail when installed as root, which may happen in a docker file, such as under github actions. While we have no explicit dependency on Module::Pluggable, our dependencies do, such as Config::Any. This is a bit of a crutch until Module::Plugable is patched. Upstream issue: simonwistow/Module-Pluggable#27
veryrusty
force-pushed
the
cpanfile-module-pluggable
branch
from
7ee41ff to
5c6d412
Compare
This way we do not have to bump EUMM
cromedome
approved these changes
Oct 30, 2024
GeekRuthie
approved these changes
Oct 30, 2024
|
Merged, thanks! |
cromedome
pushed a commit
that referenced
this pull request
Nov 25, 2024
[ BUG FIXES ]
* None
[ ENHANCEMENTS ]
* None
[ DOCUMENTATION ]
* None
[ DEPRECATED ]
* None
[ MISC ]
* PR #1715: Update deprecated download-artifact (dependabot)
* GH #1716: Remove Scope::Upper from list of recommended deps
(Russell @veryrusty Jenkins)
* PR #1718: Add Module::Pluggable as a requirement, excluding
broken versions (Russell @veryrusty Jenkins)
* PR #1719: Force install of Module::Pluggable so CI can successfully
run (Jason A. Crome, Russell @veryrusty Jenkins)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module::Pluggable added checks for unreadable files in v6.1 and v6.2. Those tests fail when installed as root, which may happen under docker, such as under github actions.
While we have no explicit dependency on Module::Pluggable, our dependencies do, such as Config::Any.
@cromedome this should be sufficient for the github actions to "just work". They run in docker containers as the root user. This is a bit of a crutch until Module::Plugable is patched. Upstream issue: simonwistow/Module-Pluggable#27