News Fixes #18
News Fixes #18
Conversation
|
Just realized how i could make registering death_msg_tbls slightly more elegant, how yay.. |
mods/news/init.lua
Outdated
| if not (type or name or msgs) then | ||
| return | ||
| end | ||
|
|
||
| if news.chat_reasons[type] then | ||
| news.chat_reasons[type][name] = msgs | ||
| for _, tbl in pairs(arg) do |
There was a problem hiding this comment.
What's arg? I suggest using for _, tbl in ipairs({...}) or using select().
There was a problem hiding this comment.
arg is a list of extra positional parameters returned from "...", its a default lua keyword, so i see no reason to change.
There was a problem hiding this comment.
The arg table was deprecated in Lua 5.1 (and does not work in Lua 5.2 or LuaJIT).
There was a problem hiding this comment.
The Minetest engine has a simple Lua API and uses Lua 5.1.
From the minetest developer wiki. I have no errors when using the keyword "arg" but if you want i can change it.
There was a problem hiding this comment.
Changing it would probably be better, some Minetest servers (any with LuaJIT libraries installed) use LuaJIT.
| "dug straight down", | ||
| } | ||
| news.register_deathmsg_tbl("nodes", lava_death_msgs, "default:lava_source", "default:lava_flowing") |
There was a problem hiding this comment.
Minor annoyance: No newline at the end of the file.
mods/news/init.lua
Outdated
| @@ -26,13 +26,15 @@ news.chat_reasons.drown = { | |||
|
|
|||
| minetest.register_privilege("news_report", {give_to_admin = true}) | |||
|
|
|||
| function news.register_deathmsg_tbl(type, name, msgs) | |||
| function news.register_deathmsg_tbl(type, msgs, ...) | |||
| if not (type or name or msgs) then | |||
There was a problem hiding this comment.
This will only return if both type, name (not defined) and msgs are all false (or nil).
There was a problem hiding this comment.
good catch, forgot to change that line
No description provided.