fix: Fix ListView itemTap not being triggered

PeterStaev · Apr 3, 2023 · 4d21a11 · 4d21a11
1 parent 0b02a11
commit 4d21a11
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 3 deletions.
diff --git a/demo/app/main-page.ts b/demo/app/main-page.ts
@@ -1,6 +1,8 @@
 /* eslint-disable no-console */
 import {
     EventData,
+    ItemEventData,
+    ListView,
     Observable,
     ObservableArray,
     Page,
@@ -28,4 +30,23 @@ export function onStar(e: EventData) {
 
 export function onDelete(e: EventData) {
     console.log("DELETE", (e.object as ViewBase).bindingContext);
+}
+
+export function onItemTap(e: ItemEventData) {
+    console.log(e.index);
+}
+
+
+export function nullifyTableViewSeparatorInsets(args: ItemEventData) {
+    if (global.isIOS) {
+        args.ios.separatorInset = UIEdgeInsetsZero;
+        args.ios.layoutMargins = UIEdgeInsetsZero;
+        args.ios.preservesSuperviewLayoutMargins = false;
+    }
+}
+
+export function nullifyEmptyCells(e: EventData) {
+    if (global.isIOS) {
+        ((e.object as ListView).ios as UITableView).tableFooterView = UIView.alloc().initWithFrame(CGRectZero);
+    }
 }
diff --git a/demo/app/main-page.xml b/demo/app/main-page.xml
@@ -1,7 +1,11 @@
 <Page xmlns="http://schemas.nativescript.org/tns.xsd" xmlns:sv="nativescript-swipe-view" navigatingTo="navigatingTo" >
     <ActionBar title="Swipe View" icon="" />
 
-    <ListView items="{{ items }}">
+    <ListView 
+        items="{{ items }}" 
+        loaded="nullifyEmptyCells"
+        itemLoading="nullifyTableViewSeparatorInsets"
+        itemTap="onItemTap">
         <ListView.itemTemplate>
             <sv:SwipeView>
                 <sv:SwipeView.leftActionsTemplate>

diff --git a/src/package.json b/src/package.json
@@ -1,6 +1,6 @@
 {
   "name": "nativescript-swipe-view",
-  "version": "1.1.0",
+  "version": "1.2.0",
   "description": "NativeScript plugin to connect with Azure Notification Hubs",
   "main": "dist/swipe-view",
   "typings": "swipe-view.d.ts",

diff --git a/src/swipe-view.ts b/src/swipe-view.ts
@@ -99,8 +99,10 @@ export class SwipeView extends GridLayout implements definition.SwipeView {
                 this._resetTransition();
             }
         });
+        this.parent?.on("itemTap", this._resetTransition.bind(this));
+
         this.on("pan", this._onPan.bind(this));
-        this.on("tap", this._resetTransition.bind(this));
+        this._swipeView.on("tap", this._resetTransition.bind(this));
     }
 
     public onUnloaded(): void {