ci: add github workflows #271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make it possible to have rust-ci-conf as a remote you merge from.
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 2 to 3. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v2...v3) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…odecov-action-3 Bump codecov/codecov-action from 2 to 3
Given that that project is unmaintained. actions-rs/toolchain#216
`cargo test --all-features` does not run doc-tests. For more information see rust-lang/cargo#6669.
This repo contains a reasonable stub of CI workflows and configuration for rust crates. It includes config for dependabot, codecov.io, and workflows for checking format and clippy, testing on multiple OSes, determining the minimum supported rust version, checking for problems with minimal versions, and runs scheduled tasks to ensure that new rust versions and dependencies do not break this crate. This is a merge using the --allow-unrelated-histories flag, that brings in the entire history of that repo. This enables the CI to be later merged if configuration changes are made upstream.
test_phf feature is incompatible with 1.32 as siphasher crate does not build
We do not have unsafe code in strum, so this is not necessary
no-std checks fail to build textwrap, which is a required dependency of structopts
Before this change, attempting to build strum_no_std would include std in the default features of strum, which would prevent it building
joshka
changed the title
|
Closing this out as too complex to solve the problem here. Will make a clearer shorter PR that is easier to consume for CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Github CI workflows to replace appveyor.
@jonhoo's ci conf repo has
a reasonable stub of CI workflows and configuration
for rust crates. It includes config for dependabot, codecov.io, and
workflows for checking format and clippy, testing on multiple OSes,
determining the minimum supported rust version, checking for problems
with minimal versions, and runs scheduled tasks to ensure that new rust
versions and dependencies do not break this crate.
This is a merge using the --allow-unrelated-histories flag, that brings
in the entire history of that repo. This enables the CI to be later
merged if configuration changes are made upstream.
I've got a PR out against the upstream repo that adds a bit more documentation
about each workflow
jonhoo/rust-ci-conf#10
Review Approach
When reviewing this change, there's two parts to consider - the history pulled in from the upstream repo which should probably not be squashed (and which contains the bulk of the implementation.
And then the changes specifically for strum which probably can be squashed into a single commit (though I have not yet done so as the commit history is relevant to understanding why specific choices were made in configuring CI
Concerns:
Testing
I ran this pull request in my own fork at https://github.com/joshka/strum/pull/1/commits with success (except for the 1.32.0 issue on Macs)