Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 compatibility #50

Merged
merged 3 commits into from
Feb 14, 2025
Merged

PHP 8.4 compatibility #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
699349c
tweak: explicit nullable type for PHP 8.4 compatibility
g105b Feb 14, 2025
79b8a66
build: php versions & ci runners
g105b Feb 14, 2025
9281427
build: ci coverage for all php versions
g105b Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 29 additions & 26 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,16 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
php: [ 8.0, 8.1, 8.2 ]
php: [ 8.1, 8.2, 8.3, 8.4 ]

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Cache Composer dependencies
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: /tmp/composer-cache
key: ${{ runner.os }}-${{ hashFiles('**/composer.lock') }}
key: ${{ runner.os }}-${{ matrix.php }}-${{ hashFiles('**/composer.lock') }}

- name: Composer install
uses: php-actions/composer@v6
Expand All @@ -27,32 +27,32 @@ jobs:
run: mkdir /tmp/github-actions/ && tar -cvf /tmp/github-actions/build.tar ./

- name: Upload build archive for test runners
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: build-artifact
name: build-artifact-${{ matrix.php }}
path: /tmp/github-actions

phpunit:
runs-on: ubuntu-latest
needs: [ composer ]
strategy:
matrix:
php: [ 8.0, 8.1, 8.2 ]
php: [ 8.1, 8.2, 8.3, 8.4 ]

outputs:
coverage: ${{ steps.store-coverage.outputs.coverage_text }}

steps:
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: build-artifact
name: build-artifact-${{ matrix.php }}
path: /tmp/github-actions

- name: Extract build archive
run: tar -xvf /tmp/github-actions/build.tar ./

- name: PHP Unit tests
uses: php-actions/phpunit@v3
uses: php-actions/phpunit@v4
env:
XDEBUG_MODE: cover
with:
Expand All @@ -62,40 +62,43 @@ jobs:
coverage_clover: _coverage/clover.xml

- name: Store coverage data
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: code-coverage
name: code-coverage-${{ matrix.php }}-${{ github.run_number }}
path: _coverage

coverage:
runs-on: ubuntu-latest
needs: [ phpunit ]
strategy:
matrix:
php: [ 8.1, 8.2, 8.3, 8.4 ]

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: code-coverage
name: code-coverage-${{ matrix.php }}-${{ github.run_number }}
path: _coverage

- name: Output coverage
run: cat "_coverage/coverage.txt"

- name: Upload to Codecov
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v5

phpstan:
runs-on: ubuntu-latest
needs: [ composer ]
strategy:
matrix:
php: [ 8.0, 8.1, 8.2 ]
php: [ 8.1, 8.2, 8.3, 8.4 ]

steps:
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: build-artifact
name: build-artifact-${{ matrix.php }}
path: /tmp/github-actions

- name: Extract build archive
Expand All @@ -112,12 +115,12 @@ jobs:
needs: [ composer ]
strategy:
matrix:
php: [ 8.0, 8.1, 8.2 ]
php: [ 8.1, 8.2, 8.3, 8.4 ]

steps:
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: build-artifact
name: build-artifact-${{ matrix.php }}
path: /tmp/github-actions

- name: Extract build archive
Expand All @@ -136,12 +139,12 @@ jobs:
needs: [ composer ]
strategy:
matrix:
php: [ 8.0, 8.1, 8.2 ]
php: [ 8.1, 8.2, 8.3, 8.4 ]

steps:
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: build-artifact
name: build-artifact-${{ matrix.php }}
path: /tmp/github-actions

- name: Extract build archive
Expand All @@ -162,7 +165,7 @@ jobs:
env:
GH_TOKEN: ${{ github.token }}
run: |
gh api "/repos/${{ github.repository }}/actions/artifacts?name=build-artifact" | jq ".artifacts[] | select(.name == \"build-artifact\") | .id" > artifact-id-list.txt
gh api "/repos/${{ github.repository }}/actions/artifacts?name=build-artifact" | jq ".artifacts[] | select(.name | startswith(\"build-artifact\")) | .id" > artifact-id-list.txt
while read id
do
echo -n "Deleting artifact ID $id ... "
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"type": "library",

"require": {
"php": ">=8.0",
"php": ">=8.1",
"ext-json": "*",
"phpgt/typesafegetter": "^1.3"
},
Expand Down
Loading