Feature/scaled sell amount #115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gulikovskiy
reviewed
Nov 5, 2024
| }); | ||
|
|
||
| initialBuyAmounts.map(async ({ asset, amount }) => { | ||
| if (isAddressEqual(asset as Address, sellToken as Address) || amount.isZero()) { |
There was a problem hiding this comment.
are you sure if amount is zero you should return an amount?
src/auto-router.ts
Outdated
| swapTarget: constants.AddressZero, | ||
| buyAssetMinAmount: scaledSellAmounts[i]!, | ||
| swapTarget: zeroAddress, | ||
| buyAssetMinAmount: scaledSellAmounts[i], |
There was a problem hiding this comment.
you can use scaledAmount here
src/auto-router.ts
Outdated
| const scaledAmount = scaledSellAmounts[i] as BigNumber; | ||
|
|
||
| // If asset is sell token or amount is zero, no swap needed | ||
| if (isAddressEqual(asset as Address, sellToken as Address) || scaledAmount.isZero()) { |
There was a problem hiding this comment.
are you sure you need to use a quote with zero amount? Maybe you should skip it?
src/auto-router.ts
Outdated
|
|
||
| const amounts = await this.indexRouter.burnAmount(indexToken, sellAmount); | ||
|
|
||
| const quotes = await Promise.all( | ||
| amounts.map(async ({ amount, asset }) => { | ||
| if (!amount || amount.isZero() || asset.toLowerCase() === routerBuyToken.toLowerCase()) { | ||
| if (isAddressEqual(asset as Address, routerBuyToken as Address) || !amount || amount.isZero()) { |
There was a problem hiding this comment.
!amount
I am not sure that amount can be nullable/undefined, can you check it please?
Gulikovskiy
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.