Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds "Other Attributes" to a Tree Node's configuration with contains non-port fields #4

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

dsobek
Copy link

@dsobek dsobek commented Dec 27, 2024

This parses and stores xml attributes to Tree nodes that are not ports so that we can parse things like _collpased for subtrees.

See https://github.com/PickNikRobotics/moveit_studio/issues/9510 for more info.

@dsobek dsobek self-assigned this Dec 27, 2024
Copy link
Collaborator

@dyackzan dyackzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you open a PR to the upstream BehaviorTree.CPP repo as well? That way we won't have to work on a fork forever

@dsobek
Copy link
Author

dsobek commented Dec 30, 2024

Could you open a PR to the upstream BehaviorTree.CPP repo as well? That way we won't have to work on a fork forever

Opened: BehaviorTree#907

@dsobek dsobek merged commit 05c0777 into master Dec 30, 2024
13 of 17 checks passed
@dsobek dsobek deleted the non-port-fields branch December 30, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants