Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebrand to MoveIt Pro #32

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Rebrand to MoveIt Pro #32

merged 1 commit into from
Jan 23, 2024

Conversation

sea-bass
Copy link
Contributor

No description provided.

@sea-bass sea-bass self-assigned this Jan 22, 2024
Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is for now just a rebranding in the documentation?

@@ -7,7 +7,7 @@ RUN --mount=type=cache,target=/var/cache/apt,sharing=locked \
apt-get update && apt-get upgrade -y && \
apt-get install -y --no-install-recommends ros-humble-rmw-cyclonedds-cpp

# Set up the MoveIt Studio SDK workspace
# Set up the MoveIt Pro SDK workspace
ENV STUDIO_SDK_WS /opt/moveit_studio_sdk_ws
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about these ones? Will they be renamed later?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We won't rename env variables or package names in this this PR.

@eholum tried this in another PR and it was... 6k lines of changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#NeverForget

README.md Show resolved Hide resolved
@sea-bass sea-bass merged commit 39f397e into main Jan 23, 2024
2 checks passed
@sea-bass sea-bass deleted the pro-rebrand branch January 23, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants