Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove error_message check, fix issue #64 #65

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Remove error_message check, fix issue #64 #65

merged 1 commit into from
Oct 22, 2024

Conversation

mkhansenbot
Copy link
Contributor

Removes the check for the error_message field which was removed in #33, fixes #64

mewtwoshaurd
mewtwoshaurd approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@mewtwoshaurd mewtwoshaurd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good to me and testing it makes sense -- could it be worth exploring opening a PR so that the SDK outputs the actual error message associate with the number (7 == pre-empted) just so people don't get confused when using the SDK?

@mewtwoshaurd
Copy link
Contributor

made an issue for the above comment: #66

@mewtwoshaurd mewtwoshaurd merged commit 3240211 into main Oct 22, 2024
2 checks passed
@mewtwoshaurd mewtwoshaurd deleted the remove_error_message_check branch October 22, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mewtwoshaurd mewtwoshaurd mewtwoshaurd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception when running example - no attribute 'error_message'
2 participants
@mkhansenbot @mewtwoshaurd