Suggestion

PicnicSupermarket · Nov 19, 2024 · 3aaa465 · 3aaa465
1 parent 83296d0
commit 3aaa465
Showing 1 changed file with 13 additions and 9 deletions.
diff --git a/pom.xml b/pom.xml
@@ -1960,12 +1960,6 @@
                                     <!-- XXX: Enable this once we open-source
                                     this library. -->
                                     -Xep:BetaApi:OFF
-                                    <!-- This check flags bad member names, but
-                                    also type names that we may want to accept.
-                                    Consider contributing a flag to toggle this
-                                    behavior. See
-                                    https://github.com/google/error-prone/issues/4616 -->
-                                    -Xep:IdentifierName:OFF
                                     <!-- We don't target JDK 7. -->
                                     -Xep:Java7ApiChecker:OFF
                                     <!-- We don't target JDK 8. -->
@@ -1981,6 +1975,9 @@
                                     <!-- XXX: Enable once there are fewer
                                     false-positives.
                                     -XepOpt:CheckReturnValue:CheckAllMethods=true -->
+                                    <!-- XXX: Consider renaming flagged types
+                                    instead. -->
+                                    -XepOpt:IdentifierName:AllowInitialismsInTypeName=true
                                     -XepOpt:InlineMe:SkipInliningsWithComments=false
                                     -XepOpt:NullAway:AnnotatedPackages=tech.picnic
                                     -XepOpt:NullAway:AssertsEnabled=true
@@ -1995,11 +1992,18 @@
                                 </arg>
                                 <!-- The Error Prone plugin makes certain
                                 assumptions about the state of the AST at the
-                                moment it is invoked. Those assumptions are met
-                                when using the `simple` compile policy. This
-                                flag may be dropped after resolution of
+                                moment it is invoked. Those assumptions require
+                                the `simple` compile policy. This flag may be
+                                dropped after resolution of
                                 https://bugs.openjdk.java.net/browse/JDK-8155674. -->
                                 <arg>-XDcompilePolicy=simple</arg>
+                                <!-- Similarly, Error Prone requires that flow
+                                analysis has been performed, e.g. to determine
+                                whether variables are effectively final. This
+                                flag may be dropped if it ever becomes the
+                                default. See
+                                https://bugs.openjdk.org/browse/JDK-8134117. -->
+                                <arg>--should-stop=ifError=FLOW</arg>
                             </compilerArgs>
                         </configuration>
                     </plugin>