Refaster redundant Mono#when statements

PicnicSupermarket · Feb 20, 2025 · 418fc05 · 418fc05
1 parent 3beadee
commit 418fc05
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ReactorRules.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ReactorRules.java
@@ -939,7 +939,7 @@ Flux<T> after(Mono<T> mono) {
   static final class MonoThen<T> {
     @BeforeTemplate
     Mono<@Nullable Void> before(Mono<T> mono) {
-      return Refaster.anyOf(mono.ignoreElement().then(), mono.flux().then());
+      return Refaster.anyOf(mono.ignoreElement().then(), mono.flux().then(), Mono.when(mono));
     }
 
     @AfterTemplate

diff --git a/...ontrib/src/test/resources/tech/picnic/errorprone/refasterrules/ReactorRulesTestInput.java b/...ontrib/src/test/resources/tech/picnic/errorprone/refasterrules/ReactorRulesTestInput.java
@@ -342,7 +342,10 @@ ImmutableSet<Flux<String>> testMonoFlux() {
   }
 
   ImmutableSet<Mono<Void>> testMonoThen() {
-    return ImmutableSet.of(Mono.just("foo").ignoreElement().then(), Mono.just("bar").flux().then());
+    return ImmutableSet.of(
+        Mono.just("foo").ignoreElement().then(),
+        Mono.just("bar").flux().then(),
+        Mono.when(Mono.just("baz")));
   }
 
   ImmutableSet<Mono<Void>> testFluxThen() {

diff --git a/...ntrib/src/test/resources/tech/picnic/errorprone/refasterrules/ReactorRulesTestOutput.java b/...ntrib/src/test/resources/tech/picnic/errorprone/refasterrules/ReactorRulesTestOutput.java
@@ -340,7 +340,8 @@ ImmutableSet<Flux<String>> testMonoFlux() {
   }
 
   ImmutableSet<Mono<Void>> testMonoThen() {
-    return ImmutableSet.of(Mono.just("foo").then(), Mono.just("bar").then());
+    return ImmutableSet.of(
+        Mono.just("foo").then(), Mono.just("bar").then(), Mono.just("baz").then());
   }
 
   ImmutableSet<Mono<Void>> testFluxThen() {