Upgrade Error Prone 2.33.0 -> 2.35.1

[Picnic-DevPla-Bot]

This PR contains the following updates:

Package	Type	Update	Change
Error Prone (source)		minor	2.33.0 -> 2.34.0
Error Prone (source)	compile	minor	2.33.0 -> 2.34.0

---

Release Notes

google/error-prone (Error Prone)

v2.34.0: Error Prone 2.34.0

Compare Source

Changes:

• Passing the javac flag --should-stop=ifError=FLOW is now required when running Error Prone (#​4595)
• The MemberName check was renamed to IdentifierName

New checks:

• FutureTransformAsync: The usage of transformAsync is not necessary when all the return values of the transformation function are immediate futures.
• MisformattedTestData: Reformats Java source code inside Error Prone test cases.
• MisleadingEscapedSpace: Using \s anywhere except at the end of a line in a text block is potentially misleading.
• ThrowIfUncheckedKnownUnchecked: throwIfUnchecked(knownUnchecked) is equivalent to throw knownUnchecked.

Closed issues: #​4595, #​4598, #​4620

Full changelog: google/error-prone@v2.33.0...v2.34.0

---

• If you want to rebase/retry this PR, check this box

[Picnic-DevPla-Bot]

Suggested commit message:

Upgrade Error Prone 2.33.0 -> 2.35.1 (#1363)

See:
- https://github.com/google/error-prone/releases/tag/v2.34.0
- https://github.com/google/error-prone/releases/tag/v2.35.0
- https://github.com/google/error-prone/releases/tag/v2.35.1
- https://github.com/google/error-prone/compare/v2.33.0...v2.35.1
- https://github.com/PicnicSupermarket/error-prone/compare/v2.33.0-picnic-2...v2.35.1-picnic-1

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[Stephan202]

Might want to do this in this PR.

[Stephan202]

This is me testing the changes for google/error-prone#4595. The build passes both without this flag and with INIT, which based on the release notes shouldn't happen. (When I replace INIT with a bogus value the compiler does complain, so the flag is not ignored.)

It appears that the issue is that flag validation happens here, while ErrorProneJavacPlugin bypasses that logic by directly invoking this method.

[Stephan202]

^ Follow-up here.

[Picnic-DevPla-Bot]

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[Stephan202]

Rebased and added a commit; bumped the version. I propose that we update the compatibility matrix after the upcoming Error Prone Support release.