-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce MicrometerRules
Refaster rule collection
#1365
Conversation
Looks good. No mutations were possible for these changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a commit with some suggestions. Only style tweaks, congrats on your first PR 🚀 !
Suggested commit message (PR title):
Introduce `MicrometerRules` Refaster rule collection (#1365)
} | ||
|
||
ImmutableSet<Iterable<Tag>> testTagsOf1() { | ||
return ImmutableSet.of(Tags.of(Tag.of("foo", "bar")), Tags.of(Tag.of("foo", "bar"))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We try to use distinct values in a test such that we are always sure it replaced the correct thing. Because the TagsOf4 and TagsOf5 have too many values to only use words like foo bar baz qux etc. I added the v1 v2 as values.
} | ||
} | ||
|
||
/** Prefer {@link Tags} over other immutable {@link Iterable}'s. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposing a slight tweak to the Javadocs :).
6f3a3b0
to
f6caa70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebased and added a comment with a future generalization suggestion, but let's merge this PR as-is 👍
Looks good. No mutations were possible for these changes. |
Quality Gate passedIssues Measures |
MicrometerRules
Refaster rule collection
Suggested commit message: