Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce MicrometerRules Refaster rule collection #1365

Merged
merged 3 commits into from
Oct 26, 2024

Conversation

danylo-naumenko
Copy link
Contributor

@danylo-naumenko danylo-naumenko commented Oct 22, 2024

Suggested commit message:

Introduce `MicrometerRules` Refaster rule collection (#1365)

Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link
Member

@rickie rickie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a commit with some suggestions. Only style tweaks, congrats on your first PR 🚀 !

Suggested commit message (PR title):

Introduce `MicrometerRules` Refaster rule collection (#1365)

}

ImmutableSet<Iterable<Tag>> testTagsOf1() {
return ImmutableSet.of(Tags.of(Tag.of("foo", "bar")), Tags.of(Tag.of("foo", "bar")));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We try to use distinct values in a test such that we are always sure it replaced the correct thing. Because the TagsOf4 and TagsOf5 have too many values to only use words like foo bar baz qux etc. I added the v1 v2 as values.

}
}

/** Prefer {@link Tags} over other immutable {@link Iterable}'s. */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposing a slight tweak to the Javadocs :).

@rickie rickie requested a review from Stephan202 October 23, 2024 07:57
@rickie rickie added this to the 0.19.0 milestone Oct 23, 2024
@Stephan202 Stephan202 force-pushed the danylo-naumenko/introduce-MicrometerRules branch from 6f3a3b0 to f6caa70 Compare October 26, 2024 12:40
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased and added a comment with a future generalization suggestion, but let's merge this PR as-is 👍

Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link

@Stephan202 Stephan202 changed the title Introduce MicrometerRules Refaster rule collection Introduce MicrometerRules Refaster rule collection Oct 26, 2024
@Stephan202 Stephan202 merged commit 56b60f5 into master Oct 26, 2024
16 checks passed
@Stephan202 Stephan202 deleted the danylo-naumenko/introduce-MicrometerRules branch October 26, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants