Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated build-helper:remove-project-artifact goal #1413

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Nov 12, 2024

Suggested commit message:

Replace deprecated `build-helper:remove-project-artifact` goal (#1413)

This resolves the following warning:

 [WARNING]  Goal 'remove-project-artifact' is deprecated: There is a similar goal: dependency:purge-local-repository <https://maven.apache.org/plugins/maven-dependency-plugin/purge-local-repository-mojo.html> By the way such goal should by not used with Maven 3/4 anymore.

(As for whether such a goal should not be used at all: (a) there's no point in caching these artifacts, and (b) we know from internal projects that keeping such SNAPSHOTs around can hide project cycles. Not likely to happen with our simple Maven build setup, but still.)

Tested as follows:

# Install project into local repository.
$ mvn clean install -DskipTests -Dverification.skip
# ...
# Validate that artifacts are now present.
$ find ~/.m2/repository/tech/picnic/error-prone-support | wc -l
88
# Run new artifact removal command.
$ mvn dependency:purge-local-repository -DmanualInclude='${project.groupId}' -DresolutionFuzziness=groupId
# ...
# Validate that artifacts are now gone.
$ ls ~/.m2/repository/tech/picnic/error-prone-support
ls: cannot access '/home/myusername/.m2/repository/tech/picnic/error-prone-support': No such file or directory

@Stephan202 Stephan202 added the chore A task not related to code (build, formatting, process, ...) label Nov 12, 2024
@Stephan202 Stephan202 added this to the 0.20.0 milestone Nov 12, 2024
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie force-pushed the sschroevers/drop-build-helper-maven-plugin branch from 2e5766e to 877a5ae Compare November 12, 2024 15:55
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 merged commit 13684ec into master Nov 13, 2024
16 checks passed
@Stephan202 Stephan202 deleted the sschroevers/drop-build-helper-maven-plugin branch November 13, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A task not related to code (build, formatting, process, ...)
Development

Successfully merging this pull request may close these issues.

3 participants