Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize AssertThatThrownBy Refaster rule #1477

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Generalize AssertThatThrownBy Refaster rule #1477

merged 1 commit into from
Dec 23, 2024

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Dec 23, 2024 •
edited
Loading

Suggested commit message:

Generalize `AssertThatThrownBy` Refaster rule (#1477)

By replacing it with the `AssertThatThrownByAsInstanceOfThrowable` and
`AssertThatThrownByIsInstanceOf` rules that are slightly more type-safe.

This resolves an issue discussed here.

@Stephan202
Generalize AssertThatThrownBy Refaster rule
466d71f 
By replacing it with the `AssertThatThrownByAsInstanceOfThrowable` and
`AssertThatThrownByIsInstanceOf` rules that are slightly more type-safe.
@Stephan202 Stephan202 added this to the 0.20.0 milestone Dec 23, 2024
@Stephan202 Stephan202 mentioned this pull request Dec 23, 2024
Merged
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

mohamedsamehsalah
mohamedsamehsalah approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@mohamedsamehsalah mohamedsamehsalah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:LGTM 🚀

rickie
rickie approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@rickie rickie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a very nice fix @Stephan202 🚀

@rickie rickie merged commit f124749 into master Dec 23, 2024
15 checks passed
@rickie rickie deleted the sschroevers/generalize-AssertThatThrownBy branch December 23, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohamedsamehsalah mohamedsamehsalah mohamedsamehsalah approved these changes

@rickie rickie rickie approved these changes

Assignees
No one assigned
Labels
improvement
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Stephan202 @rickie @mohamedsamehsalah