Generalize assorted Refaster rules #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. No mutations were possible for these changes. |
mohamedsamehsalah
approved these changes
Dec 27, 2024
|
Validated that these changes do not impact the integration tests. |
rickie
force-pushed
the
sschroevers/generalize-assorted-refaster-rules
branch
from
524e8f1 to
a72bdd2
Compare
|
Looks good. No mutations were possible for these changes. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested commit message:
This was done manually, with the help of IntelliJ IDEA's "Parameter type may be weakened" inspection. I considered writing an Error Prone check for this, but that'd be quite involved, requiring more effort than I'm willing to spend at this time.