Extend ImmutableMapRules Refaster rule collection
#1488
Conversation
Stephan202
force-pushed
the
sschroevers/extend-ImmutableMapRules
branch
from
1a97fa7 to
6ac49c4
Compare
|
Looks good. All 1 mutations in this change were killed.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
| /** | ||
| * Prefer {@link ImmutableMap.Builder#buildOrThrow()} over the less explicit {@link | ||
| * ImmutableMap.Builder#build()}. | ||
| */ | ||
| static final class ImmutableMapBuilderBuildOrThrow<K, V> { | ||
| @BeforeTemplate | ||
| ImmutableMap<K, V> before(ImmutableMap.Builder<K, V> builder) { | ||
| return builder.build(); | ||
| } | ||
|
|
||
| @AfterTemplate | ||
| ImmutableMap<K, V> after(ImmutableMap.Builder<K, V> builder) { | ||
| return builder.buildOrThrow(); | ||
| } | ||
| } |
There was a problem hiding this comment.
The builder subtypes for ImmutableBiMap and ImmutableSortedMap extend from ImmutableMap.Builder, so those build() calls are also covered.
| // XXX: We could add variants in which the entry is created some other way, but we have another | ||
| // rule that covers canonicalization to `Map.entry`. |
There was a problem hiding this comment.
Dropped, because this describes our approach more generally these days.
|
Looks good. All 1 mutations in this change were killed.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
|
Looks good. No mutations were possible for these changes. |
Stephan202
force-pushed
the
sschroevers/extend-ImmutableMapRules
branch
from
fcd022d to
b7d09da
Compare
| Map.ofEntries( | ||
| - Map.ofEntries( | ||
| + ImmutableMap.ofEntries( | ||
| entry("days", "d"), | ||
| entry("hours", "h"), | ||
| entry("minutes", "min"), |
There was a problem hiding this comment.
This isn't simplified further, because it's a long list. We could add more rules, but: meh.
|
Looks good. No mutations were possible for these changes. |
|
I set out to resolve #1223, then noticed a few other ways in which internal code can be simplified.
Suggested commit message: