Upgrade Error Prone fork 2.36.0-picnic-1 -> 2.36.0-picnic-2 #1499
Conversation
Stephan202
added
dependencies
chore
|
Looks good. No mutations were possible for these changes. |
| Pending a release of [google/error-prone#3301][error-prone-pull-3301], this | ||
| flag must currently be used in combination with `-Perror-prone-fork`. |
There was a problem hiding this comment.
This should have been deleted in the context of #685.
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-surefire-plugin</artifactId> | ||
| <configuration> | ||
| <systemPropertyVariables> | ||
| <!-- Property used by `ErrorProneForkTest` | ||
| to verify fork identification. --> | ||
| <error-prone-fork-in-use>true</error-prone-fork-in-use> | ||
| </systemPropertyVariables> | ||
| </configuration> | ||
| </plugin> |
There was a problem hiding this comment.
This should have been deleted in the context of #685.
|
Suggested commit message: |
| Packages][error-prone-fork-packages]. This fork generally contains a few | ||
| changes on top of the latest Error Prone release. Using this profile | ||
| generally requires passing `-s settings.xml`, with [suitably | ||
| configured][github-packages-auth] `GITHUB_ACTOR` and `GITHUB_TOKEN` |
There was a problem hiding this comment.
I can't find where the ACTOR comes from. Any reason we are not going for USERNAME? Maybe I'm misunderstanding 🤔.
There was a problem hiding this comment.
This variable is documented here :)
|
Is anyone going to address the bot's attempt to steal Stephan's work? 😄
|
|
I'll file a copyright claim ;) |
This new release is published using GitHub Packages rather than JitPack. This comes with a simpler release setup and a (hopefully) more stable package repository. A minor downside is that GitHub Packages require authenticated access, even for read access. The documentation has been updated accordingly. The new release is no longer published using a custom groupId, enabling some build simplifications. While there, some obsolete fork-related documentation and configuration is dropped. See: - https://github.com/PicnicSupermarket/error-prone/releases/tag/v2.36.0-picnic-2 - PicnicSupermarket/error-prone@v2.36.0-picnic-1...v2.36.0-picnic-2
Stephan202
force-pushed
the
sschroevers/github-packages
branch
from
a7426de to
08cf003
Compare
|
Looks good. No mutations were possible for these changes. |
|
Suggested commit message:
This is possible thanks to PicnicSupermarket/error-prone@a3aaf7c. See the README update for the requisite local changes. In the context of this work I also filed s4u/setup-maven-action#112.
NB: There's still a dependency on JitPack for
com.github.lhotari:reactor-error-prone. It appears that in the last few days JitPack is more stable again. Let's review this dependency if/when flakiness returns.