Drop unused Palantir {assertj,baseline}-error-prone dependencies
#367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickie
added
the
chore
.renovaterc.json
Outdated
| @@ -10,8 +10,7 @@ | |||
| }, | |||
| { | |||
| "matchPackagePatterns": [ | |||
| "^com\\.palantir\\.baseline:baseline-error-prone$", | |||
| "^ruby\/setup-ruby$" | |||
| "^ruby/setup-ruby$" | |||
There was a problem hiding this comment.
Shouldn't we escape the /?
There was a problem hiding this comment.
You are absolutely right, don't know how I changed that 🤔. Fixed it :D.
chamil-prabodha
approved these changes
Nov 23, 2022
Stephan202
force-pushed
the
rossendrijver/drop_palantir
branch
from
327e649 to
fd65439
Compare
Stephan202
approved these changes
Nov 23, 2022
.renovaterc.json
Outdated
| @@ -10,7 +10,6 @@ | |||
| }, | |||
| { | |||
| "matchPackagePatterns": [ | |||
| "^com\\.palantir\\.baseline:baseline-error-prone$", | |||
| "^ruby\/setup-ruby$" | |||
There was a problem hiding this comment.
Given that the removed like worked:
Suggested change
| "^ruby\/setup-ruby$" | |
| "^ruby\\/setup-ruby$" |
rickie
changed the title
com.palantir.{assertj-automation,baseline} dependencies{assertj,baseline}-error-prone dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a while now we have not been able to upgrade the Palantir baseline dependency. We got no response on a ticket @Stephan202 created upstream palantir/gradle-baseline#2362.
In addition to that, we didn't use the dependency yet. We discussed offline to drop the dependency for now.
Merging this will close #172.
There are two other mentions of Palantir's repositories, but I feel they are still valid and should stay.