iOS Voice Assistant #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErisMik
force-pushed
the
ios
branch
2 times, most recently
from
c68f8c1 to
d256117
Compare
laves
requested changes
Jun 4, 2024
recipes/llm-voice-assistant/ios/PicoLLMVoiceAssistantDemo/Info.plist
Outdated
Show resolved
Hide resolved
recipes/llm-voice-assistant/ios/PicoLLMVoiceAssistantDemo/AudioPlayerStream.swift
Outdated
Show resolved
Hide resolved
recipes/llm-voice-assistant/ios/PicoLLMVoiceAssistantDemo/ViewModel.swift
Outdated
Show resolved
Hide resolved
recipes/llm-voice-assistant/ios/PicoLLMVoiceAssistantDemo/ViewModel.swift
Outdated
Show resolved
Hide resolved
recipes/llm-voice-assistant/ios/PicoLLMVoiceAssistantDemo/ViewModel.swift
Outdated
Show resolved
Hide resolved
recipes/llm-voice-assistant/ios/PicoLLMVoiceAssistantDemo/ViewModel.swift
Outdated
Show resolved
Hide resolved
recipes/llm-voice-assistant/ios/PicoLLMVoiceAssistantDemo/ViewModel.swift
Outdated
Show resolved
Hide resolved
recipes/llm-voice-assistant/ios/PicoLLMVoiceAssistantDemo/PicoLLMVoiceAssistantDemoApp.swift
Outdated
Show resolved
Hide resolved
ksyeo1010
reviewed
Jun 4, 2024
recipes/llm-voice-assistant/ios/LLMVoiceAssistantDemo/ChatView.swift
Outdated
Show resolved
Hide resolved
|
I am getting some |
Yeah this happens with all our demos, you have to change the bundle identifier to something like |
….swift Co-authored-by: Kwangsoo Yeo <[email protected]>
laves
reviewed
Jun 4, 2024
recipes/llm-voice-assistant/ios/PicoLLMVoiceAssistantDemo/ViewModel.swift
Outdated
Show resolved
Hide resolved
|
@laves Can't seem to reply to your comment. Fixed it using the callbacks correctly, we now only record when needed. Also fixed a bug with not flushing the warmupPCM if it never reaches the 1 second mark. |
laves
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.