Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement generation testing for Java #1361

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Implement generation testing for Java #1361

merged 1 commit into from
Feb 5, 2025

Conversation

picoliu
Copy link
Contributor

@picoliu picoliu commented Feb 4, 2025

No description provided.

@picoliu picoliu requested a review from laves February 4, 2025 00:07
Copy link
Member

@laves laves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're also going to want to change the gradle version that the demo uses to check compatibility. See how this PR did it with gradle version: https://github.com/Picovoice/flutter-voice-processor/pull/20/files (ignore the references to flutter version and agp version)

@picoliu picoliu force-pushed the java-gen-testing branch 2 times, most recently from 6df2d8d to 9e5e150 Compare February 4, 2025 01:33
@picoliu picoliu requested a review from laves February 4, 2025 01:36
Copy link
Member

@laves laves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the confusion - only the demo action should have the generation testing. The SDK and perf actions can stay just Java 11

@laves laves merged commit 0f4b490 into master Feb 5, 2025
17 checks passed
@laves laves deleted the java-gen-testing branch February 5, 2025 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants