E2484. Reimplement participants_controller.rb #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed Assignment as foreign key from questionnaire. Co-authored-by: kmalick <[email protected]>
* Add github workflows and fixing rspec model cases. Removed Assignment as foreign key from questionnaire. * Fixing spelling issues * Fixing spelling issues --------- Co-authored-by: kmalick <[email protected]>
* Implemented authorization logic via Application controller * Integration with courses controller requiring at least Instructor level authorization * Made return values more consistent for definite role determination * Tests for authorization concern * Consistent parameter names * Added tests for all_actions_allowed? method under auth concern * Added tests for action_allowed? method under auth concern * Added tests for authorize method under auth concern * Correction in role for all_actions_allowed * Fixes in auth spec description and courses tests * Editing names of methods to make it more readable --------- Co-authored-by: anshganatra <[email protected]> Co-authored-by: kmalick <[email protected]>
* Implemented authorization logic via Application controller * Integration with courses controller requiring at least Instructor level authorization * Made return values more consistent for definite role determination * Tests for authorization concern * Consistent parameter names * Added tests for all_actions_allowed? method under auth concern * Added tests for action_allowed? method under auth concern * Added tests for authorize method under auth concern * Correction in role for all_actions_allowed * Fixes in auth spec description and courses tests * Editing names of methods to make it more readable --------- Co-authored-by: anshganatra <[email protected]> Co-authored-by: kmalick <[email protected]>
Kashika08
reviewed
Jan 24, 2025
| @@ -1,10 +1,15 @@ | |||
| class Api::V1::ParticipantsController < ApplicationController | |||
| include ParticipantsHelper | |||
|
|
|||
| # Returns true if the user has TA privileges; otherwise, denies access by returning false. | |||
| def action_allowed? | |||
| current_user_has_ta_privileges? | |||
There was a problem hiding this comment.
This is not how we check action allowed now.
has_required_role?('Teaching Assistant') is how it should be done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add action_allowed and rename a few methods - merge into expertiza#135