This repository has been archived by the owner on Nov 22, 2023. It is now read-only.
Deactivate command interface in PilzJointTrajectoryController #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SansoneG
reviewed
Jun 10, 2020
pilz_control/include/pilz_control/pilz_joint_trajectory_controller_impl.h
Outdated
Show resolved
Hide resolved
pilz_control/test/unittest_pilz_joint_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
pilz_control/test/unittest_pilz_joint_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
pilz_control/test/unittest_pilz_joint_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
pilz_control/test/unittest_pilz_joint_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
agutenkunst
force-pushed
the
deactivate/command_interface
branch
from
87d3c7d to
d91d63c
Compare
martiniil
suggested changes
Jun 15, 2020
pilz_control/test/unittest_pilz_joint_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
pilz_control/test/unittest_pilz_joint_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
SansoneG
approved these changes
Jun 15, 2020
agutenkunst
reviewed
Jun 15, 2020
hslusarek
force-pushed
the
deactivate/command_interface
branch
3 times, most recently
from
0a3e223 to
6615b60
Compare
* Add LoggerMock to pilz_testutils
hslusarek
force-pushed
the
deactivate/command_interface
branch
from
6615b60 to
7e35222
Compare
|
As part of the rebase against melodic-devel, I decided to separate some test improvements into a separate PR. To see this changes have a look at PR #411. |
jschleicher
reviewed
Jun 16, 2020
pilz_control/include/pilz_control/pilz_joint_trajectory_controller_impl.h
Outdated
Show resolved
Hide resolved
pilz_control/test/unittest_pilz_joint_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
agutenkunst
reviewed
Jun 16, 2020
pilz_control/test/unittest_pilz_joint_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
martiniil
approved these changes
Jun 16, 2020
agutenkunst
force-pushed
the
deactivate/command_interface
branch
from
5ace86e to
a3d2592
Compare
agutenkunst
force-pushed
the
deactivate/command_interface
branch
from
baf6475 to
7b26d45
Compare
jschleicher
reviewed
Jun 17, 2020
jschleicher
reviewed
Jun 17, 2020
agutenkunst
force-pushed
the
deactivate/command_interface
branch
from
6f86226 to
e764f93
Compare
agutenkunst
force-pushed
the
deactivate/command_interface
branch
from
e764f93 to
f98482c
Compare
|
@hslusarek please recheck the latest changes. After that I suggest the merge. @jschleicher ready? |
agutenkunst
force-pushed
the
deactivate/command_interface
branch
from
8f96d64 to
97dd486
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.