New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor change: remove redundant push #2

Merged

Pimm merged 1 commit into Pimm:master from maykoala:master

Mar 2, 2020

Contributor

maykoala commented Mar 2, 2020

The tail has already been concated to the result.


          remove redundant push

171d4ff

Pimm merged commit cceb6c0 into Pimm:master

Owner

Pimm commented Mar 3, 2020

Thank you for your contribution.

You did not merely remove some redundant code; you fixed a bug!

In very specific cases, that "extra" push produced incorrect results. See this new test which failed with the previous version.

So again: thank you so much! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet