Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix workflow pull-cd-builder-images2.yaml #382

Merged
merged 1 commit into from
Aug 13, 2024
Merged

ci: fix workflow pull-cd-builder-images2.yaml #382

merged 1 commit into from
Aug 13, 2024

Conversation

wuhuizuo
Copy link
Contributor

Signed-off-by: wuhuizuo [email protected]

@ti-chi-bot ti-chi-bot bot requested a review from purelind August 13, 2024 14:20
Copy link

ti-chi-bot bot commented Aug 13, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the diff, the following are the key changes made in the Pull Request:

  1. The if statement in the just-build job is updated to include a check for the presence of a specific string in the comment body and to exclude comments from issues.
  2. The run command for checking out the pull request is updated to use the gh command instead of the hub command.

As for potential problems, there are a couple of things to note:

  1. The changes made seem to be specific to the requirements of the project, and it is difficult to tell if there are any issues with the changes without more context.
  2. The dockerfile for the tikv package is updated to use a different file for fips profile. However, there are no corresponding changes made to the build_args section. This may cause issues if the BASE_IMG is not compatible with the new dockerfile.

To fix the second issue, the build_args section should be updated to use a compatible base image for the new dockerfile.

Overall, the changes seem reasonable and focused on the specific requirements of the project.

@ti-chi-bot ti-chi-bot bot added the size/S label Aug 13, 2024
@wuhuizuo
Copy link
Contributor Author

/approve

Copy link

ti-chi-bot bot commented Aug 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 13, 2024
@ti-chi-bot ti-chi-bot bot merged commit 878b876 into main Aug 13, 2024
2 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/ci branch August 13, 2024 14:25
wuhuizuo added a commit that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant