Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(packages): use go1.23 to build artifacts for experiment profile #414

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

wuhuizuo
Copy link
Contributor

Signed-off-by: wuhuizuo [email protected]

@ti-chi-bot ti-chi-bot bot requested a review from purelind September 13, 2024 03:27
Copy link

ti-chi-bot bot commented Sep 13, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, the proposed changes are to update the Go version used to build artifacts for the "experiment" profile in several packages. Specifically, the Go version is updated from 1.21 to 1.23 in the image URLs.

There don't seem to be any potential problems with this change, as it is a straightforward version update. However, it would be good to confirm that the artifacts are being built correctly with the new version of Go.

For fixing suggestions, it could be helpful to add more details to the PR description, such as why this change is necessary and how it will benefit the project. Additionally, the PR could benefit from some testing to confirm that the Go version update does not cause any issues in the build process.

@ti-chi-bot ti-chi-bot bot added the size/S label Sep 13, 2024
@wuhuizuo
Copy link
Contributor Author

/approve

Copy link

ti-chi-bot bot commented Sep 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 13, 2024
@ti-chi-bot ti-chi-bot bot merged commit dc3dd47 into main Sep 13, 2024
3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/use-go1.23-to-build branch September 13, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant